Skip to content

[test] align.wast: add tests of malformed memop flags in wasm-3.0 #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

keithw
Copy link
Member

@keithw keithw commented Mar 27, 2025

This PR adds tests for malformed binary-format memop flags to the wasm-3.0 tests.

The main-branch align.wast has malformed tests (added in #1751), but multi-memory liberalizes the encoding so the existing tests were changed to assert_invalid in multi-memory and wasm-3.0. This adds back some (more-extreme) examples of malformed flags.

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not sure align.wast is the ideal place, but I'm fine with that)

@rossberg rossberg merged commit a0a1510 into WebAssembly:wasm-3.0 Mar 27, 2025
1 check passed
@keithw keithw deleted the wasm3-malformed-memop branch March 27, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants