Skip to content

Fix relaxed laneselect to allow looking at top bit of byte #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2023
Merged

Fix relaxed laneselect to allow looking at top bit of byte #145

merged 2 commits into from
Sep 7, 2023

Conversation

ngzhian
Copy link
Member

@ngzhian ngzhian commented Jun 6, 2023

This allows using pblendvb for i16x8 lane select. See #125.

@ngzhian
Fix relaxed laneselect to allow looking at top bit of byte
2fd9172 
This allows using pblendvb for i16x8 lane select. See WebAssembly#125.
@ngzhian ngzhian requested review from rossberg and dtig June 26, 2023 00:22
@ngzhian
Copy link
Member Author

ngzhian commented Jun 26, 2023

@Maratyszcza @yurydelendik fyi

@ngzhian
Copy link
Member Author

ngzhian commented Aug 17, 2023

ping

@ngzhian
Copy link
Member Author

ngzhian commented Aug 31, 2023

ping @rossberg @dtig

rossberg
rossberg reviewed Sep 6, 2023
View reviewed changes
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, but I can't claim to know enough context to say if the semantics is defined as intended. Deferring to @dtig.

dtig
dtig approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@dtig dtig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Sorry for the delay, I'm catching up after a break.

@ngzhian ngzhian merged commit cd9c447 into WebAssembly:main Sep 7, 2023
@ngzhian ngzhian deleted the relaxed-lanesel branch September 7, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossberg rossberg rossberg left review comments

@dtig dtig dtig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngzhian @rossberg @dtig