-
Notifications
You must be signed in to change notification settings - Fork 3
Add pull request viewer #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # src/lib/ScreenSize.svelte
Also better login, adjusted GHBadge & more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After exposing my thoughts on Twitter, here is the practice: a Pull Request Viewer.
What is this?
It's a dedicated page where you can see the details of the pull request you click on from the homepage.
Most of the info you'd normally get when clicking the GitHub link is there: author, title, body, but also file changes and even the content of the closing issues!
Why?
Because it's a quick way to get the info you'd normally need to load the whole GitHub website for, because it's not that hard to make and most importantly because it's fun to make and will provide a good user experience.
Ok then what's the progress status?
Here it is:
(lots of stuff to do here, look forTODO
s in the changed files to get an idea of how close I am to being done!)Are there indirect changes you had to make?
Yes. Here they are:
@octokit/rest
tooctokit
to be able to use GraphQL (because I have to)/+layout.ts