Skip to content

Add pull request viewer #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 14, 2024
Merged

Add pull request viewer #19

merged 19 commits into from
Jul 14, 2024

Conversation

WarningImHack3r
Copy link
Owner

@WarningImHack3r WarningImHack3r commented Jul 10, 2024

After exposing my thoughts on Twitter, here is the practice: a Pull Request Viewer.

What is this?

It's a dedicated page where you can see the details of the pull request you click on from the homepage.
Most of the info you'd normally get when clicking the GitHub link is there: author, title, body, but also file changes and even the content of the closing issues!

Why?

Because it's a quick way to get the info you'd normally need to load the whole GitHub website for, because it's not that hard to make and most importantly because it's fun to make and will provide a good user experience.

Ok then what's the progress status?

Here it is:

  • Creating the buttons on the main page
    • Making them look good
    • Giving them the right link
    • Making them appear only where it's relevant
  • Creating the routes
  • Creating the view page
    • Fetching the right info
    • Displaying it (lots of stuff to do here, look for TODOs in the changed files to get an idea of how close I am to being done!)
    • Fix the last details (do responsive, check light mode, fix refreshing problem)

Are there indirect changes you had to make?

Yes. Here they are:

  • Change the Octokit library from @octokit/rest to octokit to be able to use GraphQL (because I have to)
  • Move the Octokit client creation to /+layout.ts
  • Prevent the navbar shortcut to show elsewhere than the home page

@WarningImHack3r WarningImHack3r self-assigned this Jul 10, 2024
Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2024 11:36pm

# Conflicts:
#	src/lib/ScreenSize.svelte
@WarningImHack3r WarningImHack3r marked this pull request as ready for review July 13, 2024 20:42
@WarningImHack3r WarningImHack3r merged commit d8cfe34 into main Jul 14, 2024
4 checks passed
@WarningImHack3r WarningImHack3r deleted the pull-viewer branch July 14, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant