Fix blinking badge for good #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After having introduced the feature (c596154) and attempting to fix it partly multiple times (53de4fd, a3439e1 & ee6ce3e), I'm noticing it's still not properly functioning.
you might ask. Well, because believe it or not: it works on my machine (I know, this is a first in software engineering).
Most of the fixes I made in the 3 part-commit were obvious look-at-the-code fixes, which fixed half of it (pulsing dots in the list) but not the second part of it (actual blinking badges for the segment selector).
So, as I can't start a preview (prod) build locally because of the Vercel adapter, I'm going to try reproducing it and fixing it for good using the Preview builds from Vercel in this PR.I still cannot reproduce it :/Let's do it.