This repository was archived by the owner on Sep 23, 2024. It is now read-only.
Feature: Add eth_sign button #61
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👷 Deploy request for walletconnect-example pending review. 🔨 Explore the source changes: e4497b8 |
|
You shouldn't use eth_sign anymore. That's why it was removed |
|
😮 Thanks! |
|
@mikheevm more context on this here: WalletConnect/walletconnect-monorepo#1395 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on
eth_signfeature in the Gnosis Safe WalletConnect app, for testing purposes I added a button for testing the call in the dapp. Thought it may be useful for other developers. I also added.env.example