fix: bugs with tab-handling in text-input
mode
#962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes 2 bugs that occurs when pressing TAB while using
text-input
mode:Bug: If you write a date and press tab, the focus will go to the clear-button. When tabbing away from the button (either back to input, or further down the page), the value will reset because it fetches the value from the wrong element.
Fix: The value is now fetched directly from the
inputRef
inhandleTab
. This is because the previous code would get the value fromev.target
which will be the clear-button (<button>
) when TAB'ing.Bug: When pressing TAB, the focus switches to the clear-button. However, the string is not automatically parsed.
I would expect the string to be parsed as soon as i pressed TAB, even though the focus shifts to the clear-button. I have therefore updated the
handleTab
to do that.Issue ticket number and link
Fixes #961
Checklist before requesting a review