Skip to content

fix: Arrow not positioned correctly when the field at the most right #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

allusernamestakenexceptthis
Copy link
Contributor

@allusernamestakenexceptthis allusernamestakenexceptthis commented Jun 25, 2024

this is a fix for issue #920

the bug:

the popup arrow is not pointing to the center of the field, when the field is on the right most of the area and there is not enough screen width to center the popup. This issue seems solved only when it is on the left via issue #802.

the fix:

I added check for the right side. if there is not enough width, then position arrow to middle of input.

tests

done, no issue locally. but pull request showing one failed test.
npm run test:coverage and npm run test works fine locally

proof

Screenshot 2024-06-25 09 55 36 msedge GGO

and it works for other situations, left and default
Screenshot 2024-06-25 09 55 56 msedge 8a1
Screenshot 2024-06-25 09 53 59 msedge cF9

@allusernamestakenexceptthis allusernamestakenexceptthis changed the title fix arrow not positioned correctly when field at most right fix: arrow not positioned correctly when field at most right Jun 25, 2024
@allusernamestakenexceptthis allusernamestakenexceptthis changed the title fix: arrow not positioned correctly when field at most right fix: Arrow not positioned correctly when the field at the most right Jun 25, 2024
@Jasenkoo Jasenkoo merged commit 3504cd0 into Vuepic:main Jun 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants