fix: Add safe navigation to arrow position calculation #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add safe navigation to arrow position calculation to prevent errors when any of the elements in the calculation does not exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with the
arrowPoscalculation that throws a null reference error if theinputRectis undefined. This can happen when using theinlinemode of the date picker.I can't reproduce this in an isolated environment (e.g. jsfiddle) but it happens every time in our project. We've added a temporary work around with
:config="{ arrowLeft: '0px' }".Ideally, this computed calculation should not even need to run when in
inlinemode, but safe navigating inside it is also a viable solution to handle this issue.