Skip to content

fix: vite warning in console #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Conversation

ayrtonandino
Copy link
Contributor

While working on #1109 I noticed that when running the dev script, it displays the following warning in console:

The condition "types" here will never be used as it comes after both "import" and "require" [package.json]

Describe your changes

  • Update package.json, move exports.".".types to the top of the list
  • Run lint script, changes ArrowBtn.vue adds missing .value to ref elRef

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have ensured that unit tests pass without errors

Update package.json

Running dev script shows the following warning: The condition "types" here will never be used as it comes after both "import" and "require" [package.json]
add type definitions to defineEmits.
disable vue/no-ref-as-operand on line 42 (prevents eslint to chenge elRef to elRef.value)
@ayrtonandino ayrtonandino requested a review from Jasenkoo March 31, 2025 14:31
@Jasenkoo Jasenkoo merged commit a072ad9 into Vuepic:main Mar 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants