Skip to content

Possible DOM memory leak? #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lightwalker01 opened this issue Mar 3, 2023 · 2 comments
Closed

Possible DOM memory leak? #302

lightwalker01 opened this issue Mar 3, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@lightwalker01
Copy link

Describe the bug
When VueDatePicker component is added to and then removed from DOM, many detached objects remain even after GC.

To Reproduce
Steps to reproduce the behavior:

  1. Go to this NPM Playground
  2. Open browser DevTools (i'm using Edge) and select "Detached Objects" tab
  3. Select app target
    image
  4. Get detached elements
    image
  5. Click the "clickme" button inside the playground to see the calendar
    image
  6. Click another time to hide the calendar
  7. Launch GC
    image
  8. Get detached elements
    image

Expected behavior
There are no DOM detached objects

Desktop & mobile (please complete the following information):

  • M$ Edge 110.0.1587.57
  • Vue 3.2.47
  • VueDatePicker 4.1.0
@lightwalker01 lightwalker01 added the bug Something isn't working label Mar 3, 2023
@Jasenkoo
Copy link
Contributor

Jasenkoo commented Mar 3, 2023

@lightwalker01 Nice catch, thank you for reporting this After some investigation, discovered that the actual cause for this are SVG icons. Will need to investigate a little why this is happening.

@lightwalker01
Copy link
Author

@Jasenkoo I thought it was because of “click outside” directive or something like that…
Thanks for your very fast resolution!
Next Monday I will update the package on my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants