-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callback on include #727
Closed
Closed
Callback on include #727
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
23be010
Full structure implemented, callback available. TODO: actually use th…
edhoedt c985465
Importing files via external callback fully implemented and working
edhoedt 45513f0
Merge branch 'master' of https://github.com/VirusTotal/yara into call…
edhoedt 4a3c839
Removing useless comments
edhoedt 99391a3
Adding documentation
edhoedt df2c1df
Updating doc for include callbacks
edhoedt dc2d3fa
Fixing compiler_set_include_callback's signature
edhoedt e98f434
Fixing issues according to @plusvic 's advice
edhoedt 92877db
* fixing memory management issues in callbacks
edhoedt aeaf59a
fixing missing pointer cast
edhoedt 3fd1434
re-generating lexer.c
edhoedt b8fe347
removing imports ununsed since commit 92877db48e408126ce0631b85c03d47…
edhoedt d084696
fixing default file read callback
edhoedt 0b86464
Fixing line numbers in errors
edhoedt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of exposing all these functions as part of the API I would do something simpler but even more flexible. Add an argument to
yr_compiler_set_include_callback
which is a pointer to thefree
function that YARA should use to deallocate the memory returned by the callback. This way the program can use whatever allocator it wants, as long as the program provides the appropriatefree
function. The program could even use a statically allocated buffer and pass YARA a NULL instead of a pointer to thefree
function, indicating the buffer don't need to be de-allocated at all. For example: