-
Notifications
You must be signed in to change notification settings - Fork 852
VCST-3343: Prevent loading stale .html templates #2916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
fix: Prevent loading stale .html templates by packing them into dist\app.js. Development mode will still read the HTML file from disk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.237
Timestamp: 26-05-2025T14:32:01
…t the template is loaded and compiled, regardless of cache status and Override an existing template with a custom one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.488
Timestamp: 27-05-2025T17:41:36
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.37
Timestamp: 28-05-2025T07:02:47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.606
Timestamp: 02-06-2025T15:16:20
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.552
Timestamp: 03-06-2025T10:34:25
Description
feat: Prevent loading stale .html templates by packing them into dist\app.js. Development mode will still read the HTML file from disk.
feat: Added platformWebApp.dynamicTemplateService that allows to ensure that the template is loaded and compiled, regardless of cache status and override an existing template with a custom one.
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-3295
Artifact URL:
Image tag:
ghcr.io/VirtoCommerce/platform:3.890.0-pr-2916-c9c9-vcst-3295-pack-html-c9c9ff17