Skip to content

adding lua support to meson build #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

erikyuzwa
Copy link
Contributor

  • Updated meson.build for the conversation code
  • Added a lua.wrap

@daremon
Copy link

daremon commented Apr 21, 2025

Hi @erikyuzwa. I just managed to compile this and your PR was very helpful!

However I followed a different route for lua and avoided fetching it as it's already included in ThirdParty/lua.

Also some more changes were needed in order to compile with:

  • freshly downloaded "Microsoft Visual Studio Community 2022 (64-bit) - Current
    Version 17.13.6"
  • meson 1.7.1

I'm attaching my meson.build where I did the minimum changes to the master branch meson.build. I liked your refactorings so maybe you can try and merge my changes?

I wonder why you didn't face a problem with glad.h - you see I had to fix that too for my case.

meson.build.txt

@erikyuzwa
Copy link
Contributor Author

thanks @daremon - I'll take a look!

I wonder why you didn't face a problem with glad.h - you see I had to fix that too for my case.

I did run into that!!! I must've overlooked that in the initial PR - thanks!

@erikyuzwa
Copy link
Contributor Author

okay it's updated now @daremon - just waiting on the missing U7Player.h fix 🙏

@daremon
Copy link

daremon commented Apr 22, 2025

Great!

Regarding U7Player I just added the source and it was OK, like this:

...
    'Source/U7Object.cpp',
    'Source/U7Player.cpp',  <--- I just added this
    'Source/WorldEditorState.cpp',
...

Regarding glad.h I don't think the change in ShapeData.cpp is needed since you added the raylib_external_include part. For me it works without changing anything in ShapeData.cpp.

@erikyuzwa
Copy link
Contributor Author

ok the proper U7Player.h has been merged into this PR!
Check it out @daremon and see what you think. I'm able to now run it locally via Meson in CLion! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants