Skip to content

Modify Kotlin flag handling #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop/1.12.0
Choose a base branch
from

Conversation

sschr15
Copy link
Member

@sschr15 sschr15 commented Apr 9, 2025

This gets rid of the redundant ProtobufFlags interface in favor of (a modified version of) the Kotlin Metadata Flags class. I would like input on this change, along with how the code looks when referencing said flags.

sschr15 added 2 commits April 9, 2025 00:37
Also whoops classes never had `inline` (they've had `value` this whole time)
Copy link

github-actions bot commented Apr 9, 2025

Test Results

   18 files  ±0     18 suites  ±0   1m 4s ⏱️ +2s
1 939 tests ±0  1 939 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 574 runs  ±0  2 574 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d94b73d. ± Comparison against base commit fec7cd2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant