Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configuration screen for Custom query parameters #256

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

tommysitehost
Copy link
Contributor

@tommysitehost tommysitehost commented Mar 11, 2025

For #252

Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments

@dmitryk-dk dmitryk-dk requested a review from Loori-R March 11, 2025 12:42
Loori-R
Loori-R previously approved these changes Mar 11, 2025
Copy link
Contributor

@Loori-R Loori-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just fix the remaining comments.

@tommysitehost
Copy link
Contributor Author

Sorry I amended my commit, hope this is ok

Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmitryk-dk
Copy link
Contributor

Sorry I amended my commit, hope this is ok

Could you please sign your commit. Because we can't merge unsigned commits

@tommysitehost
Copy link
Contributor Author

oops sorry, forgot to add my gpg key up. should be good now

Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmitryk-dk dmitryk-dk merged commit cd9f89a into VictoriaMetrics:main Mar 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants