Refactor EntityManager injections to avoid conflict between WidgetCss command and WidgetMapDataWarmer #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The WidgetMapManipulator class name seems too generic, I would préfère something like "WidgetPositionComputer", what do you think @leny |
paulandrieux
added a commit
that referenced
this pull request
Nov 16, 2015
Refactor EntityManager injections to avoid conflict between WidgetCss command and WidgetMapDataWarmer
|
I don't know why I'm being mentionned here. Probably a typo? |
|
@leny this is a mistake from @paulandrieux who wanted to mention @lenybernard the Lead Dev of Victoire's project. Sorry for this :) |
|
No problem. Glad it's just a typo, I'm not very good at naming things. 😃 |
|
👍 You've been saved ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.