Skip to content

chore: remove legacy package tag in AndroidManifest.xml #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 26, 2024

Conversation

alestiago
Copy link
Contributor

Description

Related to #156 and #160

From the documentation:

In the Gradle-based build system, starting with AGP 7.3, don't set the package value in the source manifest file directly. For more information, see Set the application ID.

Current example AGP version is 7.3

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago added the product: very_good_wear_app Changes that affect the Very Good Wear App template. label Jul 26, 2024
@alestiago alestiago self-assigned this Jul 26, 2024
@alestiago alestiago requested a review from a team as a code owner July 26, 2024 14:01
@alestiago alestiago changed the title chore: remove legacy package tag in AndroidManifest.xml #160 chore: remove legacy package tag in AndroidManifest.xm Jul 26, 2024
@alestiago alestiago changed the title chore: remove legacy package tag in AndroidManifest.xm chore: remove legacy package tag in AndroidManifest.xml Jul 26, 2024
@alestiago alestiago merged commit 6ec7bab into main Jul 26, 2024
5 checks passed
@alestiago alestiago deleted the alestiago/very_good_wear_app branch July 26, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: very_good_wear_app Changes that affect the Very Good Wear App template.
Projects
Development

Successfully merging this pull request may close these issues.

1 participant