Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Route --version output to stdout #1431

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neo-anderson
Copy link

Currently, saml2aws --version prints the application version to stderr. This change modifies the behavior to print the version string to stdout instead while other logs and errors remain on stderr.

Reasoning:

Printing the version to stdout aligns better with common scripting practices and standard CLI tool behavior for version reporting. This makes it easier to capture the version string programmatically without needing stderr redirection (2>&1).

For example, users with bootstrapping or environment setup scripts that check dependency versions currently need to add special handling for saml2aws like

version = result.stdout.strip() if tool != "saml2aws" else result.stderr.strip()

or like

VERSION=$(saml2aws --version 2>&1)

Routing --version output to stdout removes this inconsistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant