Add --try-no-prompt flag
#1428
Open
Add --try-no-prompt flag
#1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--try-no-prompt uses credentials from non-interactive sources, if possilbe. Otherwise it prompts the user to enter these credentials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--try-no-promptuses credentials from non-interactive sources, if possilbe.Otherwise it prompts the user to enter these credentials.This optimizes the workflow by eliminating the need to press enter when valid credentials are present, while allowing to have them added to the keyring without the need to rerun the command (as would be necessary with
--no-prompt).--no-promptis still available for non-interactive usecases (see discussion in #101). This also creates an obvious place in the interface to add the functionality discussed in #101.Naming of the new flag is open for discussion. Its placement (
loginFlagsvscommonFlags) is as well.Unfortunately, I do not have an overview over all the use cases for saml2aws. If these changes hinder any use case, guidance is much appreciated. Same goes for general use of the Go language.