fix: 🐛 improve password confirmation prompt (fixes #1390) #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the saml2aws configure command prompted users with "Confirm" after entering their password. This wording was ambiguous, leading many users to press "Enter" instead of re-entering their password, which resulted in an unclear error message stating "Passwords did not match." Since no second password was actually entered, the error message did not effectively communicate the issue, causing confusion. After this change, the prompt explicitly asks users to "Enter password" and "Re-enter password" to confirm. Additionally, the error message has been updated to "Confirmed password does not match" for better clarity. The logic has also been refactored to reduce unnecessary nesting and improve readability. This change enhances the user experience by making the password confirmation process more intuitive, preventing authentication failures due to unclear instructions. Signed-off-by: Sriram Venkatesh <[email protected]>
srizzling
changed the title
pwmcintyre
reviewed
Mar 24, 2025
Comment on lines
+57
to
+61
| repeat := prompter.Password("Re-enter password") | ||
| if repeat != password { | ||
| log.Println("Confirmed password does not match") | ||
| os.Exit(1) | ||
| } |
There was a problem hiding this comment.
is this a good idea? 💭
Suggested change
| repeat := prompter.Password("Re-enter password") | |
| if repeat != password { | |
| log.Println("Confirmed password does not match") | |
| os.Exit(1) | |
| } | |
| for { | |
| if password == prompter.Password("Re-enter password") { | |
| break | |
| } | |
| log.Println("Confirmed password does not match") | |
| } |
There was a problem hiding this comment.
spicy opinion: password repeaters are annoying
Suggested change
| repeat := prompter.Password("Re-enter password") | |
| if repeat != password { | |
| log.Println("Confirmed password does not match") | |
| os.Exit(1) | |
| } |
There was a problem hiding this comment.
Agree with repeat. For sign up: maybe? for logins: NO. let's delete?
There was a problem hiding this comment.
its one time during configure operation.. so I guess if a user gets a password wrong.. we are just assuming they will just do it again.
Seems okay to me.
ary-b
reviewed
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the saml2aws configure command prompted users with "Confirm" after entering their password. This wording was ambiguous, leading many users to press "Enter" instead of re-entering their password, which resulted in an unclear error message stating "Passwords did not match." Since no second password was actually entered, the error message did not effectively communicate the issue, causing confusion.
After this change, the prompt explicitly asks users to "Enter password" and "Re-enter password" to confirm. Additionally, the error message has been updated to "Confirmed password does not match" for better clarity. The logic has also been refactored to reduce unnecessary nesting and improve readability.
This change enhances the user experience by making the password confirmation process more intuitive, preventing authentication failures due to unclear instructions.
fixes #1390