Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "saml2aws configure" CLI prompting #1390

Open
ary-b opened this issue Feb 4, 2025 · 1 comment · May be fixed by #1418
Open

Improve "saml2aws configure" CLI prompting #1390

ary-b opened this issue Feb 4, 2025 · 1 comment · May be fixed by #1418
Assignees
Labels
component:cli Issues related to the command-line interface priority:low Minor issue, nice-to-have type:enhancement Indicates new feature requests

Comments

@ary-b
Copy link

ary-b commented Feb 4, 2025

TLDR: "Passwords did not match" is solved by entering the password again when prompted "Confirm" rather than pressing "Enter" to confirm.

When running the saml2aws configure command to login with Okta, the user is prompted Confirm after entering the password. This seems like a very unintuitive way to ask the user to input the same password again. It leads user to press "Enter" to confirm their inputs.

The error message "Passwords did not match" also doesn't make it explicit that the entered password and the confirmed one don't match (obviously because there isn't any confirmed password) and leaves the user perplexed, trying to understand which 2 passwords don't match.

Image

This can be very simply solved by changing the "Confirm" wording to something like "Confirm entered password" or "Enter password again", which is exactly what the CLI is trying to make the user do. An alternative would be to change the error message to "Confirmed password doesn't match".

I tried to open a pull request but I don't have the right permissions to do it. I hope this can be considered as a small but considerable improvement. Cheers!

@ary-b ary-b changed the title Improve "Configure CLI" prompting Improve "aws2saml configure" CLI prompting Feb 4, 2025
@ary-b ary-b changed the title Improve "aws2saml configure" CLI prompting Improve "saml2aws configure" CLI prompting Feb 4, 2025
@tayyeb-ali
Copy link

Thanks @ary-b I had the same problem. Very ambiguous prompt for a user input here...

@RossRichardson RossRichardson added the type:enhancement Indicates new feature requests label Mar 15, 2025
srizzling added a commit that referenced this issue Mar 24, 2025
Prior to this change, the saml2aws configure command prompted users with
"Confirm" after entering their password. This wording was ambiguous,
leading many users to press "Enter" instead of re-entering their
password, which resulted in an unclear error message stating "Passwords
did not match." Since no second password was actually entered, the error
message did not effectively communicate the issue, causing confusion.

After this change, the prompt explicitly asks users to "Enter password"
and "Re-enter password" to confirm. Additionally, the error message has
been updated to "Confirmed password does not match" for better clarity.
The logic has also been refactored to reduce unnecessary nesting and
improve readability.

This change enhances the user experience by making the password
confirmation process more intuitive, preventing authentication failures
due to unclear instructions.

Signed-off-by: Sriram Venkatesh <[email protected]>
@RossRichardson RossRichardson added component:cli Issues related to the command-line interface priority:low Minor issue, nice-to-have labels Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:cli Issues related to the command-line interface priority:low Minor issue, nice-to-have type:enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants