Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
I realize now that when I set up the first recommended events, I only included required fields as documented here. In other cases, I or others included fields that aren't required in the recommended events, like
item_list_name
anditem_list_id
in theview_item_list
event.This PR adds those non-required parameters to ecommerce events.
I realize now that we should have a discussion on how to handle it. We either only add the required fields and then make our documentation clear that fields that aren't marked as required need to be added as custom parameters, or we default to adding all of the parameters listed in the recommended events docs.
Checklist
dbt test
andpython -m pytest .
to validate existing tests