Skip to content

update standard ecommerce params #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2023
Merged

Conversation

dgitis
Copy link
Collaborator

@dgitis dgitis commented May 16, 2023

Description & motivation

I realize now that when I set up the first recommended events, I only included required fields as documented here. In other cases, I or others included fields that aren't required in the recommended events, like item_list_name and item_list_id in the view_item_list event.

This PR adds those non-required parameters to ecommerce events.

I realize now that we should have a discussion on how to handle it. We either only add the required fields and then make our documentation clear that fields that aren't marked as required need to be added as custom parameters, or we default to adding all of the parameters listed in the recommended events docs.

Checklist

  • I have verified that these changes work locally
  • [] I have updated the README.md (if applicable)
  • [ n/a] I have added tests & descriptions to my models (and macros if applicable)
  • I have run dbt test and python -m pytest . to validate existing tests

@dgitis
Copy link
Collaborator Author

dgitis commented May 17, 2023

I should have opened an Issue to discuss this first, but only realized what the issue was when I was preparing a PR. @adamribaudo and @willbryant, please comment on whether to include event parameters from recommended events that are documented but not required in our staging models.

@adamribaudo-velir
Copy link
Collaborator

I don't have a strong opinion here. This is clearly an improvement from the current state so I'm happy to merge.

@adamribaudo-velir adamribaudo-velir merged commit c3481c1 into main May 24, 2023
@adamribaudo-velir adamribaudo-velir deleted the recommended-events branch May 24, 2023 10:24
@adamribaudo-velir adamribaudo-velir restored the recommended-events branch May 30, 2023 10:11
@dgitis dgitis deleted the recommended-events branch August 10, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants