Skip to content

Update Docker Image to Ubuntu 24.04 ( Noble ) #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 76 commits into from
May 16, 2025

Conversation

pentatonicfunk
Copy link
Contributor

@pentatonicfunk pentatonicfunk commented Oct 20, 2024

Checks

  • I've updated the changelog.
  • I've tested this PR: Partially
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

Note on testing:

  • Currently i only have linux host testing machine. I've tested with Docker provider, and it went okay, logs attached
  • Tried using Virtualbox, but it keeps timing out / error
Timed out while waiting for the machine to boot. This means that
Vagrant was unable to communicate with the guest machine within
the configured ("config.vm.boot_timeout" value) time period.

If you look above, you should be able to see the error(s) that
Vagrant had when attempting to connect to the machine. These errors
are usually good hints as to what may be wrong.

If you're using a custom box, make sure that networking is properly
working and you're able to connect to the machine. It is a common
problem that networking isn't setup properly in these boxes.
Verify that authentication configurations are also setup properly,
as well.

If the box appears to be booting properly, you may want to increase
the timeout ("config.vm.boot_timeout") value.
  • If anyone can help testing it, please

Changelogs:

  • Please advise

tomjn and others added 23 commits September 10, 2022 11:55
- Add OVH url in hosts_to_test ( keep the mariadb.gb.ssimn.org )
- Better messages
Copy link

update-docs bot commented Oct 20, 2024

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@pentatonicfunk pentatonicfunk requested a review from tomjn October 20, 2024 02:44
@tomjn
Copy link
Member

tomjn commented Oct 20, 2024

@pentatonicfunk how much of this can we split into separate PRs? Upgrading Ubuntu isn't a small task but adding the sources could be done and released pretty quickly to simplfy merging. Likewise some of the other changes are useful and quick to test on their own.

I am mindful that upgrading Ubuntu the last time resulted in some weirdness that needed investigation.

Also, the service changes, I was thinking of changing how services are restarted to use a VVV specific function to insulate against service and systemctl since there's a lot of duplication going on

@pentatonicfunk
Copy link
Contributor Author

i will try to cherry picks into separate branches next week.

This was referenced Oct 20, 2024
@tomjn
Copy link
Member

tomjn commented Apr 29, 2025

Running this locally with:

act -j 'on-docker' --container-architecture linux/arm64 -P ubuntu-24.04=ghcr.io/catthehacker/ubuntu:act-24.04

@tomjn
Copy link
Member

tomjn commented May 16, 2025

TLDR the symlinks were the problem

@tomjn
Copy link
Member

tomjn commented May 16, 2025

@pentatonicfunk it's been a long time coming but I think it's time to merge

@tomjn tomjn merged commit efcb93c into Varying-Vagrant-Vagrants:develop May 16, 2025
4 checks passed
Copy link

welcome bot commented May 16, 2025

Congrats on merging your first pull request!

tomjn added a commit that referenced this pull request May 21, 2025
* 3.15 cycle starts

* Update CHANGELOG.md

* Create eol.yml

* Run EOL check on main branches on push/PR

* Attempt to solve shyaml pip install

* Fix dpkg version compare relation arg

* Update Docker Image to Ubuntu 24.04 ( Noble ) (#2739)

* Attempt to fix git safe dir issue
- wildcard

* Fix git safe.directory script

* Update mariadb repo to OVH for ubuntu focal
- Add OVH url in hosts_to_test ( keep the mariadb.gb.ssimn.org )

* Use `mysql` as service name in docker

* Use `mysql` as service name in docker -- vagrant_up

* Attempt to dynamically get mysql service name

* Fix inverted `vvv_get_mysql_service_name`

* Fix syntax issue
- Better messages

* More messages fix

* Attempt to add more Ubuntu noble repo list

* Dummy vvv sources list for noble

* Attempt to solve shyaml pip install

* Fix dpkg version compare relation arg

* Allow custom PHP CLI version

* Use ubuntu 24.04 as default image for docker provider

* Revert git safe dir setup

* Fix comments copy in provision/core/mariadb/provision.sh

Co-authored-by: Tom J Nowell <[email protected]>

* Update Changelog

* Revert "Allow custom PHP CLI version"

This reverts commit c705505.

* Revert "Fix syntax issue"

This reverts commit 87ba465.

* Revert "Fix inverted `vvv_get_mysql_service_name`"

This reverts commit c798cef.

* Revert "Attempt to dynamically get mysql service name"

This reverts commit 30b8230.

* Revert "Use `mysql` as service name in docker -- vagrant_up"

This reverts commit bbcf60d.

* Revert "Use `mysql` as service name in docker"

This reverts commit 4c38733.

* Minor script adjustment #2739 (comment)

* Revert "Minor script adjustment #2739 (comment)"

This reverts commit 3e6aec5.

* Improve OS version number check on `shyaml_setup`

* Update eol.yml weith ubuntu 24

* Update vvv-provisioning.yml to use Ubuntu 24

* Update Vagrantfile with Ubuntu 24 boxes for non-docker providers

* Remove noroot from home env setup and instead chown at the end to ensure ownership

* adjust ssh service reload check

* setup git config values in the vvv provisioner test action

* Update provision.sh

* Attempt to fix permissions for PHPCS provisioner

* Update provision.sh

* Update provision.sh

* Setup /srv/www with permissions

* Improve set up of /srv/www/phpcs

* Update provision.sh

* Force docker github action set up to noninteratice mode

* Use noninteractive mode for vagrant setup

* Refactor git-lfs apt key and sources

* phpcs permission tweaks

* set exec flag on phpcs

* Remove chmod 755 in PHPCS provisioner

* adjust phpcs provisioner to output more information on failing to set the default standard

* Fix command susbtitution in PHPCS provisioner

* Execute PHP rather than phpcs directly to avoid noexec as a possible failure point in GH runners

* Improve noroot to flag when no vagrant user is detected and fallback

* Update PHPCS permission setting

* Check mount options and apparmor/seccomp presence/options

* Improve check mount options

* Improve debugging output for PHPCS

* chmod in the vendor folder bin too

* remove GH action environment checks and try to use the new container directly

* remove GH action step to set PR rebase

* Avoid symlinking www and instead copy it

* Reorder symlink step

* Github action cleanup

* whitespace fixes for EOL action

* Updated changelog with Ubuntu 24 changes

---------

Co-authored-by: Tom J Nowell <[email protected]>

* Fix the user of config.vm vs override.vm (#2754)

* fix the user of config.vm vs override.vm

* Update changelog

* Simplify >= 0 box version requirement

* Remove the mount share option on parallels (#2755)

* set empty mounts so that dmode and fmode aren't inherited on parallels (#2756)

* Mount options cleanup (#2757)

* Set parallels mount optionss to nonempty, add mount optionss to more places, and move mount option values to array variables. Some minor cleanup of duplicated synced folder definitions

* Update changelog

* consistent whitespace in vagrantfile mount option declarations

* Update Vagrantfile with docker xdebug ports (#2748)

* Update Vagrantfile with docker xdebug ports

Attempts to add a port mapping for docker to support port 9003 for xdebug

* Xdebug port changelog

* Docker provision fixes (#2758)

* Improve docker mounts by removing unsupported options

* Fix getfacl on non-Ubuntu 24, and make PHPCS permission setting non-failing

* Refactor MariaDB root password setting (#2738)

* Refactor MariaDB root password setting

It looks like newer versions of Mariadb need a different method for doing this, also we weren't shutting it down and running in the right mode to set the new password

* Update provision.sh

* flush mariadb privs to load grants before modifying them

* Improved db backup and restore (#2759)

* Ubuntu 24 provision enhancements (#2760)

* Fix random locations appearing in the provisioner log when cd - is used

* Fix the phpcs provisioner failing to chmod files inside .git folders

* Fix NVM folder being printed

* Silence rsync nginx command

* Fix two booleans being printed when checking cpu arch in mailhog provisioner

* Strip escape codes out of logs (#2742)

* Strip escape codes out of logs

Colour and bold formatting gets put in the log files too which can make reading them difficult, this commit attempts to strip them out

* change the sed expression that strips out formatting

* Fix stripping out colours in the log files

* tab spacing fixes

* log colour stripping changelog

* Provisioning enhancements May 2025 (#2761)

* Update changelog and version field for v3.15.1 (#2762)

---------

Co-authored-by: Hendrawan Kuncoro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants