-
Notifications
You must be signed in to change notification settings - Fork 846
Update Docker Image to Ubuntu 24.04 ( Noble ) #2739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docker Image to Ubuntu 24.04 ( Noble ) #2739
Conversation
- wildcard
…-Vagrants/develop v3.11 PR
…-Vagrants/develop 3.11.2 on stable
…-Vagrants/develop 3.12 stable
…-Vagrants/develop v3.1.2 stable
# Conflicts: # provision/core/git/provision.sh
- Add OVH url in hosts_to_test ( keep the mariadb.gb.ssimn.org )
- Better messages
Thanks for opening this pull request! Make sure
|
@pentatonicfunk how much of this can we split into separate PRs? Upgrading Ubuntu isn't a small task but adding the sources could be done and released pretty quickly to simplfy merging. Likewise some of the other changes are useful and quick to test on their own. I am mindful that upgrading Ubuntu the last time resulted in some weirdness that needed investigation. Also, the service changes, I was thinking of changing how services are restarted to use a VVV specific function to insulate against |
i will try to cherry picks into separate branches next week. |
Running this locally with:
|
…r into docker-provider
… the default standard
…failure point in GH runners
TLDR the symlinks were the problem |
@pentatonicfunk it's been a long time coming but I think it's time to merge |
Congrats on merging your first pull request! |
* 3.15 cycle starts * Update CHANGELOG.md * Create eol.yml * Run EOL check on main branches on push/PR * Attempt to solve shyaml pip install * Fix dpkg version compare relation arg * Update Docker Image to Ubuntu 24.04 ( Noble ) (#2739) * Attempt to fix git safe dir issue - wildcard * Fix git safe.directory script * Update mariadb repo to OVH for ubuntu focal - Add OVH url in hosts_to_test ( keep the mariadb.gb.ssimn.org ) * Use `mysql` as service name in docker * Use `mysql` as service name in docker -- vagrant_up * Attempt to dynamically get mysql service name * Fix inverted `vvv_get_mysql_service_name` * Fix syntax issue - Better messages * More messages fix * Attempt to add more Ubuntu noble repo list * Dummy vvv sources list for noble * Attempt to solve shyaml pip install * Fix dpkg version compare relation arg * Allow custom PHP CLI version * Use ubuntu 24.04 as default image for docker provider * Revert git safe dir setup * Fix comments copy in provision/core/mariadb/provision.sh Co-authored-by: Tom J Nowell <[email protected]> * Update Changelog * Revert "Allow custom PHP CLI version" This reverts commit c705505. * Revert "Fix syntax issue" This reverts commit 87ba465. * Revert "Fix inverted `vvv_get_mysql_service_name`" This reverts commit c798cef. * Revert "Attempt to dynamically get mysql service name" This reverts commit 30b8230. * Revert "Use `mysql` as service name in docker -- vagrant_up" This reverts commit bbcf60d. * Revert "Use `mysql` as service name in docker" This reverts commit 4c38733. * Minor script adjustment #2739 (comment) * Revert "Minor script adjustment #2739 (comment)" This reverts commit 3e6aec5. * Improve OS version number check on `shyaml_setup` * Update eol.yml weith ubuntu 24 * Update vvv-provisioning.yml to use Ubuntu 24 * Update Vagrantfile with Ubuntu 24 boxes for non-docker providers * Remove noroot from home env setup and instead chown at the end to ensure ownership * adjust ssh service reload check * setup git config values in the vvv provisioner test action * Update provision.sh * Attempt to fix permissions for PHPCS provisioner * Update provision.sh * Update provision.sh * Setup /srv/www with permissions * Improve set up of /srv/www/phpcs * Update provision.sh * Force docker github action set up to noninteratice mode * Use noninteractive mode for vagrant setup * Refactor git-lfs apt key and sources * phpcs permission tweaks * set exec flag on phpcs * Remove chmod 755 in PHPCS provisioner * adjust phpcs provisioner to output more information on failing to set the default standard * Fix command susbtitution in PHPCS provisioner * Execute PHP rather than phpcs directly to avoid noexec as a possible failure point in GH runners * Improve noroot to flag when no vagrant user is detected and fallback * Update PHPCS permission setting * Check mount options and apparmor/seccomp presence/options * Improve check mount options * Improve debugging output for PHPCS * chmod in the vendor folder bin too * remove GH action environment checks and try to use the new container directly * remove GH action step to set PR rebase * Avoid symlinking www and instead copy it * Reorder symlink step * Github action cleanup * whitespace fixes for EOL action * Updated changelog with Ubuntu 24 changes --------- Co-authored-by: Tom J Nowell <[email protected]> * Fix the user of config.vm vs override.vm (#2754) * fix the user of config.vm vs override.vm * Update changelog * Simplify >= 0 box version requirement * Remove the mount share option on parallels (#2755) * set empty mounts so that dmode and fmode aren't inherited on parallels (#2756) * Mount options cleanup (#2757) * Set parallels mount optionss to nonempty, add mount optionss to more places, and move mount option values to array variables. Some minor cleanup of duplicated synced folder definitions * Update changelog * consistent whitespace in vagrantfile mount option declarations * Update Vagrantfile with docker xdebug ports (#2748) * Update Vagrantfile with docker xdebug ports Attempts to add a port mapping for docker to support port 9003 for xdebug * Xdebug port changelog * Docker provision fixes (#2758) * Improve docker mounts by removing unsupported options * Fix getfacl on non-Ubuntu 24, and make PHPCS permission setting non-failing * Refactor MariaDB root password setting (#2738) * Refactor MariaDB root password setting It looks like newer versions of Mariadb need a different method for doing this, also we weren't shutting it down and running in the right mode to set the new password * Update provision.sh * flush mariadb privs to load grants before modifying them * Improved db backup and restore (#2759) * Ubuntu 24 provision enhancements (#2760) * Fix random locations appearing in the provisioner log when cd - is used * Fix the phpcs provisioner failing to chmod files inside .git folders * Fix NVM folder being printed * Silence rsync nginx command * Fix two booleans being printed when checking cpu arch in mailhog provisioner * Strip escape codes out of logs (#2742) * Strip escape codes out of logs Colour and bold formatting gets put in the log files too which can make reading them difficult, this commit attempts to strip them out * change the sed expression that strips out formatting * Fix stripping out colours in the log files * tab spacing fixes * log colour stripping changelog * Provisioning enhancements May 2025 (#2761) * Update changelog and version field for v3.15.1 (#2762) --------- Co-authored-by: Hendrawan Kuncoro <[email protected]>
-- Add missing
noble
repository list-- Hacky fix of pip shyaml install on Ubuntu 24.04: see https://pimylifeup.com/python-externally-managed-environment/
vvv_get_mysql_service_name
, in attempt to improvemariadb
vsmysql
service inconsistency-- Unable to replicate the service name inconsistency, but it happened. ref: Slack #docker
general.php_cli_version
-- It does have use case for me personally at least
-- Generally this provides user with better control of PHP CLI version rather than meddling / replicating
vvv_restore_php_default
to change PHP CLI version: https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org/blob/main/docs/en-US/adding-a-new-site/changing-php-version.md?plain=1#L83Checks
develop
branch not thestable
branch.Note on testing:
Changelogs: