Skip to content

Prefer native versions of various DLLs #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2,453 commits into
base: bleeding-edge
Choose a base branch
from

Conversation

Tiagoquix
Copy link

@Tiagoquix Tiagoquix commented Dec 17, 2024

This PR aims to address ValveSoftware/Proton#8308.

A previous issue of mine was already addressed by this commit.

This PR extends the same effects of that commit to all various other DLLs that can be used by https://github.com/ThirteenAG/Ultimate-ASI-Loader/releases/latest (excluding non-existent DLLs under Wine dlls folder such as the Bink ones).

Caveats

This approach, in general, has already been rejected upstream. See the discussion in https://gitlab.winehq.org/wine/wine/-/merge_requests/6527 for more details (specifically, this comment).

From what I understand, upstream plans to enhance the DLL loading mechanism to solve those cases of native vs. built-in. However, for the time being, this should bring a quality-of-life change to gamers that want to add mods to their games.

Please see the aforementioned Proton issues and their comments for more details regarding security risks.

Thanks for your attention.

Edit: to complement, this is the opinion of Paul Gofman, responsible for the "prefer native dinput8.dll" commit in this repository:

my opinion is that these overrides suck, we'd better have a better way to detect but noone came up with it yet. Maybe we can choose something very wide used to add, not sure if that is winhttp.

rbernon and others added 30 commits September 18, 2024 16:21
This is an indication that the source has ended, and that the session is
about to end, but not that all the samples in the session have been
decoded and processed.

CW-Bug-Id: #20833

CW-Bug-Id: #20833
CW-Bug-Id: #20833

CW-Bug-Id: #20833
…ranscoded stream.

CW-Bug-Id: #21303
CW-Bug-Id: #22008

CW-Bug-Id: #20833
…eate transform.

CW-Bug-Id: #21303
CW-Bug-Id: #23630

CW-Bug-Id: #20833
…more formats.

Fixes missing video in Devil May Cry HD Collection / DMC1.

CW-Bug-Id: #20833
Fixes garbled first frame in ARK: Survival Evolved.

CW-Bug-Id: #20833
Fixes some garbled video frames when the texture is later used as input
by the video processor.

CW-Bug-Id: #20833
h264parse does not correctly determine 'nal' alignment if this caps is
provided.

CW-Bug-Id: #23226
CW-Bug-Id: #23425
Yuxuan Shui and others added 26 commits December 11, 2024 21:20
Include a line number of the call site.

(cherry picked from commit 5613917)
(cherry picked from commit 09c6f48)
MIDI tracks don't map one-to-one to segment tracks, so it doesn't make sense to use a
"get_next_track()" interface.

(cherry picked from commit aebcb1a)
Preparation for supporting setting TempoParam on tempotracks.

(cherry picked from commit 6a3f067)
And add some tests.

(cherry picked from commit 1b1f216)
Adding them to the seqtrack, and also implementing playing them from the seqtrack.

(cherry picked from commit 28b94c4)
This makes us be able to pass custom data in codec data buffer.

CW-Bug-Id: #24374
CW-Bug-Id: #23630
CW-Bug-Id: #21303
CW-Bug-Id: #21304
CW-Bug-Id: #24374
CW-Bug-Id: #23630
CW-Bug-Id: #21303
CW-Bug-Id: #21304
CW-Bug-Id: #24374
CW-Bug-Id: #23630
CW-Bug-Id: #21303
CW-Bug-Id: #21304
CW-Bug-Id: #24374
CW-Bug-Id: #23630
The tests indicate that for dmo_wrapper_sink_Receive:
(1) If ProcessOutput succeeds, including S_FALSE, it continue processing.
(2) If ProcessOutput fails, it returns S_OK.
(3) If downstream Receive fails or return S_FALSE, it returns downstream hr.

(cherry picked from commit fe7674a)
CW-Bug-Id: #24585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.