-
Notifications
You must be signed in to change notification settings - Fork 277
Prefer native versions of various DLLs #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tiagoquix
wants to merge
2,453
commits into
ValveSoftware:bleeding-edge
Choose a base branch
from
Tiagoquix:prefer-native
base: bleeding-edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Prefer native versions of various DLLs #266
Tiagoquix
wants to merge
2,453
commits into
ValveSoftware:bleeding-edge
from
Tiagoquix:prefer-native
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CW-Bug-Id: #20833
…ray. CW-Bug-Id: #20833
…default streams. CW-Bug-Id: #20833
…ia source. CW-Bug-Id: #20833
CW-Bug-Id: #20833
… file. CW-Bug-Id: #20833
…Type. CW-Bug-Id: #20833
…ssing. CW-Bug-Id: #20833
…or seek. CW-Bug-Id: #20833
CW-Bug-Id: #20833
CW-Bug-Id: #20833
…cond if not set. CW-Bug-Id: #20833
This is an indication that the source has ended, and that the session is about to end, but not that all the samples in the session have been decoded and processed. CW-Bug-Id: #20833 CW-Bug-Id: #20833
CW-Bug-Id: #20833 CW-Bug-Id: #20833
…nts. CW-Bug-Id: #20833
…ranscoded stream. CW-Bug-Id: #21303 CW-Bug-Id: #22008 CW-Bug-Id: #20833
…eate transform. CW-Bug-Id: #21303 CW-Bug-Id: #23630 CW-Bug-Id: #20833
CW-Bug-Id: #20833
CW-Bug-Id: #20833
…errupted. CW-Bug-Id: #20833
…more formats. Fixes missing video in Devil May Cry HD Collection / DMC1. CW-Bug-Id: #20833
Fixes garbled first frame in ARK: Survival Evolved. CW-Bug-Id: #20833
Fixes some garbled video frames when the texture is later used as input by the video processor. CW-Bug-Id: #20833
h264parse does not correctly determine 'nal' alignment if this caps is provided. CW-Bug-Id: #23226 CW-Bug-Id: #23425
…ided. CW-Bug-Id: #20833
CW-Bug-Id: #20833
Include a line number of the call site. (cherry picked from commit 5613917)
(cherry picked from commit 09c6f48)
MIDI tracks don't map one-to-one to segment tracks, so it doesn't make sense to use a "get_next_track()" interface. (cherry picked from commit aebcb1a)
(cherry picked from commit 05347b9)
(cherry picked from commit 29f73d6)
Preparation for supporting setting TempoParam on tempotracks. (cherry picked from commit 6a3f067)
And add some tests. (cherry picked from commit 1b1f216)
(cherry picked from commit f0fc4a0)
… track. (cherry picked from commit 1df0e34)
(cherry picked from commit 5ff9435)
Adding them to the seqtrack, and also implementing playing them from the seqtrack. (cherry picked from commit 28b94c4)
This makes us be able to pass custom data in codec data buffer. CW-Bug-Id: #24374 CW-Bug-Id: #23630
CW-Bug-Id: #21303 CW-Bug-Id: #21304 CW-Bug-Id: #24374 CW-Bug-Id: #23630
CW-Bug-Id: #24374 CW-Bug-Id: #23630
CW-Bug-Id: #21303 CW-Bug-Id: #21304 CW-Bug-Id: #24374 CW-Bug-Id: #23630
CW-Bug-Id: #21303 CW-Bug-Id: #21304 CW-Bug-Id: #24374 CW-Bug-Id: #23630
(cherry picked from commit 2412054)
(cherry picked from commit 49858a7)
…ils. (cherry picked from commit eee10e9)
The tests indicate that for dmo_wrapper_sink_Receive: (1) If ProcessOutput succeeds, including S_FALSE, it continue processing. (2) If ProcessOutput fails, it returns S_OK. (3) If downstream Receive fails or return S_FALSE, it returns downstream hr. (cherry picked from commit fe7674a)
(cherry picked from commit 29b6975)
…riKiri games. CW-Bug-Id: #24567
CW-Bug-Id: #24585
CW-Bug-Id: #24585
SteavenGamerYT
approved these changes
Feb 18, 2025
Visne
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address ValveSoftware/Proton#8308.
A previous issue of mine was already addressed by this commit.
This PR extends the same effects of that commit to all various other DLLs that can be used by https://github.com/ThirteenAG/Ultimate-ASI-Loader/releases/latest (excluding non-existent DLLs under Wine
dlls
folder such as theBink
ones).Caveats
This approach, in general, has already been rejected upstream. See the discussion in https://gitlab.winehq.org/wine/wine/-/merge_requests/6527 for more details (specifically, this comment).
From what I understand, upstream plans to enhance the DLL loading mechanism to solve those cases of native vs. built-in. However, for the time being, this should bring a quality-of-life change to gamers that want to add mods to their games.
Please see the aforementioned Proton issues and their comments for more details regarding security risks.
Thanks for your attention.
Edit: to complement, this is the opinion of Paul Gofman, responsible for the "prefer native dinput8.dll" commit in this repository: