Properly detect whether podman or docker should be used. #8443
+50,841
−749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, and only on this list so far is Guild Wars 2 (1284210) CW-Bug-Id: #23824
CW-Bug-Id: #23808 SteamAppId isn't set for InstallScripts, but this variable is.
This reverts commit a090d16.
CW-Bug-Id: #22729
To keep SDL 2.30 old behavior until we start supporting it. CW-Bug-Id: #23185
CW-Bug-Id: #23185
In some cases, wget -O will create the file even when the download fails. This is not removed by make and will make subsequent failures more confusing, as well as failing to recover if the cause was an intermittent network failure.
These files are copied into lib(64)/wine/dxvk with user-write permission, which is later removed by default_pfx: rule. Hence failing to 'cp' upon update.
…numerateSwapchainImages.
…ack_message_utow even if Unix len is unknown. CW-Bug-Id: #23875
CW-Bug-Id: #23874
CW-Bug-Id: #22421
No-op but make_specfiles reads .specs and make_vulkan updates one.
CW-Bug-Id: #23916
CW-Bug-Id: #23924
That path can be relative when the build directory is inside the Proton source directory. Since it then used to patch compile_commands.json, it is important that it is absolute, otherwise it implicitly becomes grafted to a directory for which it is meaningless.
CW-Bug-Id: #23962
CW-Bug-Id: #23962
Plagman
force-pushed
the
bleeding-edge
branch
19 times, most recently
from
f72dace to
7aee6ab
Compare
Plagman
force-pushed
the
bleeding-edge
branch
11 times, most recently
from
8a1d14e to
b84f537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora ships podman with a podman-docker package that uses a bash script for /usr/bin/docker which runs
exec /usr/bin/podman @, This does not work correctly with the current check mechanism in proton's configure script, resulting in invalid permission settings:By checking if the /usr/bin/docker file contains contains 'bin/podman' we can easily determine whether or not to actually use podman before any other checks are done.