Skip to content

Create a wine prefix per user #4861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: proton_6.3
Choose a base branch
from

Conversation

Maykin-99
Copy link

Fixes #4820 by setting the base directory of CompatData from steamapps/compatdata/<steamid>/ to steamapps/compatdata/<steamid>/<userid>/ (I'm honestly surprised that it worked without a hitch).

The only issue is that the old files still exist.
Ideally we would move them to the new path.
I assume that would belong in upgrade_pfx? Or is it even necessary?

Fixes ValveSoftware#4820 by setting the base directory of `CompatData` from `steamapps/compatdata/<steamid>/` to `steamapps/compatdata/<steamid>/<userid>/`  (I'm honestly surprised that it worked without a hitch).

The only issue is that the old files still exist.
Ideally we would move them to the new path.
I assume that would belong in `upgrade_pfx`? Or is it even necessary?
@Maykin-99 Maykin-99 closed this May 26, 2021
@Maykin-99 Maykin-99 deleted the patch-1 branch May 26, 2021 12:34
@Maykin-99 Maykin-99 restored the patch-1 branch May 26, 2021 12:34
@Maykin-99 Maykin-99 reopened this May 26, 2021
@VannTen
Copy link

VannTen commented Feb 20, 2022

How could we make this progress forward ?
I just got it by the exact same problem when trying to make family sharing work.

@Nomz420
Copy link

Nomz420 commented Mar 29, 2022

Could someone look into this? This fix would prove really useful for us.

@CorruptComputer
Copy link

Does this break Steam Cloud save backups? Might need some coordination with the Steam folks to make sure this doesn't break existing save backups.

@jessecambon
Copy link

+1 also related to ValveSoftware/steam-for-linux#3942

@etyarews
Copy link

etyarews commented Sep 8, 2024

+1 This would fix so many issues

@eilimrib
Copy link

eilimrib commented Mar 1, 2025

Please. This is giving me nightmare having to recompile Proton just to share my games with my wife.

eilimrib added a commit to eilimrib/proton-ge-custom that referenced this pull request Mar 1, 2025
@Damglador
Copy link

@eilimrib you don't have to compile it. Since it's a change in a simple python file, you can just do the same change in already installed Proton version

@Damglador
Copy link

Perhaps it's better to store prefixes in the local compatdata? Because in case user1 with 1000 and user2 with 1001 on the first system won't get swapped prefixes on a system where user1 is 1001 and user2 is 1000

@shaft8472
Copy link

So, I found that this is the reason why I cannot let my two sons make use of the same gamedata as my account. Seems like a simple fix.

@Damglador
Copy link

I would do this as a personal patch:

self.base_dir = os.path.join(os.environ["STEAM_COMPAT_CLIENT_INSTALL_PATH"], "steamapps", "compatdata", os.environ["SteamAppId"]) + "/"

Or, from my understanding, Steam just could supply a local compatdata directory in STEAM_COMPAT_DATA_PATH variable, instead of the one in portable library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proton not working when multiple Linux users share a single installation path
10 participants