Skip to content

add tests to osx build script #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2024
Merged

add tests to osx build script #333

merged 1 commit into from
Sep 8, 2024

Conversation

AminSojoudi
Copy link
Contributor

Tests were added as new steps to the OSX workflow.
#178

@zpostfacto
Copy link
Contributor

Thanks! And it looks like the tests detected a problem with my new TOS-reading code.

@gabeochoa gabeochoa mentioned this pull request Sep 6, 2024
Closed
@zpostfacto zpostfacto merged commit 37fcabf into ValveSoftware:master Sep 8, 2024
1 of 3 checks passed
@zpostfacto
Copy link
Contributor

Thanks!
I am not sure if the test is still broken or not, but either way, it's a real break that needs to be fixed.

@AminSojoudi
Copy link
Contributor Author

My Pleasure,
I have tried the tests on older commits and they passed with success. I believe the test process is fine. However, I'm not sure if the failed test is wrong or something inside the library is broken in recent commits.

@zpostfacto
Copy link
Contributor

There are recent commits that are almost certainly the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AminSojoudi @zpostfacto