Fix normal command double quote bug #9430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent_normal_command
s-kai273
commented
Jan 11, 2025
| @@ -113,7 +113,7 @@ const escapedParser = string('\\') | |||
| export const keystrokesExpressionParser: Parser<string[]> = alt( | |||
| escapedParser, | |||
| specialCharacterParser, | |||
| noneOf('"'), | |||
| regexp(/./), | |||
There was a problem hiding this comment.
Due to the use of noneOf('"'), parsing parameters that contain double quotes fails.
However, I believe that including double quotes is not an invalid case in normal command.
If replacing the original parser with regexp(/./) introduces other issues, please let me know!
J-Fields
reviewed
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes
#9431
Special notes for your reviewer: