fun fact: this has been running in prod for a while #1146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because of `setUserSelectedTimeslot` being static (because it sets it in the session), it considers it the GET method. By pure chance in the last 2.5 years, when going through the methods, it looked at setUST first, said it was the get method, then saw getUST and overwrote that as the GET method, but now it's seeing them in the other order, so overwrites getUST with setUST as the GET method. Because there's no ordering to the methods, just the order they happen to appear in, and we've been relying on getUST coming second. I put it in as an edge case cause it kinda is - static method setting a thing essentially 'globally'
…1136) Co-authored-by: Marks Polakovs <[email protected]>
ashhhleyyy
reviewed
Feb 21, 2024
Dockerfile.prod
Outdated
| @@ -0,0 +1,55 @@ | |||
| FROM php:7.4-apache | |||
There was a problem hiding this comment.
this will need updating to 8.2 when #1142 is merged
* Upgrade development Dockerfile to PHP 8 * Fixes to get the setup process to work OOTB * Upgrade to PHP 8.2 and xdebug 3.3.1 * Remove redundant patch (see 2.sql) * Update schema version
ashhhleyyy
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
few things:
Then, we can have what's running be up to date with github again, and can then give it to jenkins now the new version is running mostly ok.