Duplicate config and config inheritance

[LlGC-jop]

UV version:

 universalviewer@all

I'm submitting a:

• bug report => please fork one of these codesandbox examples with a repro of your issue and include a link to it below
• feature request => please use the user stories repo
• support request => Please do not submit support requests here, use stackoverflow

Current behavior:

Currently in default config there is duplication of certain settings which means that implementations would have to account for this, which would require implementers to know about it in the first place. This can be confusing at best, and while it does allow for flexibility, it feels messy.

For example, we have downloadEnabled in the footerPanel settings. But it's also present in mobileFooterPanel and searchFooterPanel. All default to true.

This means that setting it to false in footerPanel doesn't actually do anything. You would have to know that the other settings section impact it as well.

The same happens with requiredStatementEnabled in centerPanel and openSeadragonCenterPanel.

I've tried removing the option from the relevant child types, because they seem to inherit/extend a 'higher' type, but TS errors.

Expected behavior:

It's something for us to discuss, but I feel that a config setting should only need to be define by a user once, and if we can allow for flexible configs

Steps to reproduce:

In a default setup, change footerPanel's downloads to be false. The download button will still appear.

[demiankatz]

I strongly agree, @LlGC-jop. Indeed, my ancient issue #171 makes a similar proposal (though more narrowly scoped -- you've certainly done a better job of defining the problem here). I even attempted an implementation in #172 which led to a long conversation but was eventually closed without being merged. I haven't refreshed my memory on any of that recently, but it may be worth revisiting if we're going to tackle this to see if any ideas remain relevant.