Fix incorrect calculations of row pitch in d3d12 implementation #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a 160x144 texture, the pitch would be aligned to be 1024 pixels wide, not 768 as D3D12 calculates it to be. This was causing issues on our end, where we would be drawing pixels with offsets that would accumulate over each row of pixels.
The width does not need to be a power of 2 - it turns out it just needs to be a multiple of 256, which is what
D3D12_TEXTURE_DATA_PITCH_ALIGNMENTis defined to be.