Skip to content

param --wait-ready not working in cluster_mode #2890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yuzhigang33 opened this issue May 20, 2017 · 4 comments
Closed

param --wait-ready not working in cluster_mode #2890

yuzhigang33 opened this issue May 20, 2017 · 4 comments
Labels
P3: Medium S: Pending Release SYS: Daemon T: Bug

Comments

@yuzhigang33
Copy link

yuzhigang33 commented May 20, 2017 •
edited
Loading

What's going wrong?

When i run the example app wait_ready, it's not working. The app start online immediately.

How could we reproduce this issue?

cd examples/wait-ready
pm2 start ecosystem.json

Supporting information

PM2 version: `2.4.6`
Node version: `7.10.0`
Windows? Mac? Linux?
MacOS Sierra 10.12.4
@yuzhigang33 yuzhigang33 changed the title wait-ready --wait-ready param is not work in cluster_mode May 20, 2017
@yuzhigang33 yuzhigang33 changed the title --wait-ready param is not work in cluster_mode param --wait-ready not working in cluster_mode May 20, 2017
@yuzhigang33
Copy link
Author

@vmarchaud
Hi, does cluster_mode support '--wait-ready' option ?
I find this pr: #2472 , but the code is missing in the latest version.

@vmarchaud
Copy link
Contributor

vmarchaud commented May 22, 2017 •
edited
Loading

@yuzhigang33 Don't know why the example doesn't work but i'm sure the code is on the latest version

@evollu
Copy link
Contributor

evollu commented May 24, 2017 •
edited
Loading

from the code cluster_mode doesn't support wait-ready
https://github.com/Unitech/pm2/blob/master/lib/God.js#L194

@vmarchaud is there any reason why it is only implemented for fork mode?

@evollu evollu mentioned this issue May 25, 2017
Merged
vmarchaud added a commit that referenced this issue May 25, 2017
@vmarchaud
(tests) fix test broken with random hostname + re-add test for wait-r…
f5c192c 
…eady in cluster mode #2890
@vmarchaud
Copy link
Contributor

Published under PM2 2.5

inerc pushed a commit to inerc/pm2 that referenced this issue Feb 11, 2020
@vmarchaud
(tests) fix test broken with random hostname + re-add test for wait-r…
10bb595 
…eady in cluster mode Unitech#2890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3: Medium S: Pending Release SYS: Daemon T: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yuzhigang33 @vmarchaud @evollu