pm2 with cron_restart restarts process while the process is still running

[rachel-benh]

If reporting a bug, please use the following template.

Expected behaviour

I need to prevent restarting script if the former didn't terminate

Actual behaviour

The script restarts

Steps to reproduce

...

Software versions used

OS         :
node.js    : 4.4.0
PM2        : latest

PM2 Log output

Use the command: tail --lines 50 ~/.pm2/pm2.log

PM2 App [temp] with id [1] and pid [43887], exited with code [0] via signal [SIGINT]
PM2 Starting execution sequence in -fork mode- for app name:temp id:1
PM2 App name:temp id:1 online
PM2 Starting execution sequence in -fork

I tried listening to process.on('SIGINT', function() {..}
to prevent exit if the script wan't done but it doesn't seem to enter the function.
Same for process.on('message', function(msg)

Thanks!

[Unitech]

Could you please double check that it does not enters in the SIGINT function.

Something else, increase kill_timeout

[rachel-benh]

Hi,
thanks.
I created

 process.on('SIGINT', function() {
    process.stdout.write('received SIGINT');
...
}

And there weren't any log prints.
I already tried setting "kill_timeout": 3000

[rachel-benh]

we tried to listen to exit and that worked...
Is there a configuration to prevent pm2 from stopping running scripts?

[Yontih]

+1
Same for me, cron restarts the process while the process is still running.

[vmarchaud]

Cause the cron is running process.exit(0) from inside the process, the process itself do not receive the SIGINT.
Feel free to make a PR to fix that.

[Yontih]

@vmarchaud it is looks like the cron is running process.exit with status code 0 not 1 ProcessContainerFork.js line 25

[vmarchaud]

@Yontih Mybad i corrected my answer, but it doesnt change anything.

[Unitech]

Thanks for the PR @Yontih, just made some change to harden the cron workflow (restart instead of raw kill) + some tests

You can try it:

$ npm install Unitech/pm2#development -g
$ pm2 update

[Yontih]

@Unitech
What if god.js (pm2) will manage the crons (start/restart child_process) instead of every child_process to run is own cron?
For example: I have a script that I want to run everyday at 00:00, I wont be able to kill my script process when it finish is work, because the cron will die as well and my script will never run again.

[Unitech]

Landed in latest PM2 stable

$ npm install pm2@latest -g

[Unitech]

@Yontih sounds interesting, PR welcome

[zackees]

Also hitting this with using cron. All python processes spawned with ProcessPoolExecutor remain alive after job completion.