Git call running 100% CPU

[thoreinstein]

PM2: 0.12.10
IOJS: v.1.5.1
OS: Ubuntu 12.04.4 LTS

I am seeing this with a crashed process that is attempting to restart. It seems to be coming from:
https://github.com/keymetrics/vizion/blob/07638d9e90e969829fee36ad0912e5464667186b/lib/git.js#L27

I honestly don't see what the git log has to do with attempting to restart a crashed process, or why it chews up CPU.

[jshkurti]

It comes from the vizion module which grabs metadata about the repository.
Which version of vizion do you have ?

[jshkurti]

It does indeed refresh the metadata at each restart.

[jshkurti]

Normally, these commands are really fast, they shouldn't stay on htop for long but just in case there is a timeout of 60s by default to cancel them if they did not succeed.

[thoreinstein]

The installed vizion version is 0.2.5, installed on this system yesterday. I understand what it is doing, I don't understand why. Timeout or no, they are still pegging the CPU at 100%+ sometimes with an individual process.

[Unitech]

@jshkurti we should reduce the timeout to 5-3secs instead of 60s

[jshkurti]

@janders223 we will implement a --no-vizion flag soon so you could completely remove this feature.

[jshkurti]

Hi @janders223, check out the new release of PM2 https://github.com/Unitech/PM2/releases
You can now specify --no-vizion flag when you start an app so it won't do any git commands at all ;)

[thoreinstein]

While I appreciate the work, this seems like a band-aid for a larger underlying problem. Have you spent any time at all to investigate the actual issue reported here?

[jshkurti]

What happens when you LC_ALL=en_US.UTF-8 git show --quiet --format=%H%n%aD%n%s%n%B HEAD manually in the folder of your app ?
Does it take a long time to finish ?

[jshkurti]

Hmm actually vizion isn't supposed to execute multiple parallel instances but when a restart occurs we refreshed the flag value.
I fixed that: eb5b2fa
Can you give it a try please ? Now it should not spawn 15 git commands anymore.
npm i -g git://github.com/Unitech/PM2#development

[thoreinstein]

That seems to have helped.

[jshkurti]

Thanks for the feedback 👍