Skip to content

Inconsistency in the way FACTORY_ADDRESS is defined and used #274

@llopez

Description

@llopez

There seems to be an inconsistency in how FACTORY_ADDRESS is defined and consumed across the codebase. In some places, it is expected to be of type Address, while in others it is treated as a plain string

if we do this
https://github.com/Uniswap/v3-subgraph/blob/main/config/matic/chain.ts#L3

it fails in this line
https://github.com/Uniswap/v3-subgraph/blob/main/src/common/constants.ts#L14

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions