Improve swap routing guide #1023
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces improvements in three main areas of the guide:
Missing imports: The sample code was missing imports for
StateLibrary
and thePoolKey
type, which are required for the code to compile correctly.Universal Router interface: Replacing the direct contract instantiation with the
IUniversalRouter
interface solves the following Solidity error:Explicit type conversion not allowed from non-payable "address" to "contract UniversalRouter", which has a payable fallback function. (solidity 7398)
This also brings consistency with how other external contracts (
PoolManager
,Permit2
) are handled via interfaces.Currency type unwrap: Unwrapping
key.currency1
using theCurrency
type fromv4-core
fixes the following error:Explicit type conversion not allowed from "Currency" to "contract IERC20". (solidity 9640)