-
Notifications
You must be signed in to change notification settings - Fork 622
Open
Description
In V4 Burn Position flow, there seems to be 2 errors:
- There should be two actions:
Actions.BURN_POSITION
(0x03
) andActions.TAKE_PAIR
(0x11
), not justActions.BURN_POSITION
to actually resolve the deltas; otherwise it reverts here: https://github.com/Uniswap/v4-core/blob/d9f8bfd39070b6114f2cf6c49df570fd6f998edb/src/PoolManager.sol#L111 - The actions should be abi encoded as follows:
bytes memory actions = abi.encodePacked(uint8(Actions.BURN_POSITION), uint8(Actions.TAKE_PAIR));
and not
bytes memory actions = abi.encodePacked(Actions.BURN_POSITION, Actions.TAKE_PAIR);
so, wrapping the actions into uint8()
Metadata
Metadata
Assignees
Labels
No labels