fix: fuzz test, increase fuzz runs #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongeric
approved these changes
Feb 24, 2025
| @@ -7,15 +7,12 @@ library ModeDecoder { | |||
| // Mode layout adhering to ERC-7579 | |||
| // 1 byte | 1 byte | 4 bytes | 4 bytes | 22 bytes | |||
| // CALL_TYPE | EXEC_TYPE | UNUSED | MODE_SELECTOR | MODE_PAYLOAD | |||
|
|
|||
There was a problem hiding this comment.
I think that we want the function to revert if the EXACT mode is not specified. So the only mode we support rn is batched calls. In the old code if the call type is batched calls but the unused bytes are dirtied it would just set it to be a batched call but I think thats actually incorrect behaviour. it should have to be the exact mode
zhongeric
added a commit
that referenced
this pull request
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.