Skip to content

Excessive data passed to reactorCallback #174

@wjmelements

Description

@wjmelements

The following information is not useful to an IReactorCallback implementation, and can be passed as fillData if actually necessary:

  • ResolvedOrder.OrderInfo (all fields)
  • ResolvedOrder.sig
  • ResolvedOrder.hash
  • ResolvedOrder.InputToken.maxAmount

Reducing the data passed to the function will reduce the memory footprint of the execution scope and therefore the gas.

[edit: added to list of unnecessary fields]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions