Skip to content

Damage calculation #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 13, 2020
Merged

Damage calculation #89

merged 5 commits into from
Oct 13, 2020

Conversation

MickVermeulen
Copy link
Member

Fixes multiple issues:

  • Damage calculation is redone
  • Race conditions in the packet handling and sync skill handling
  • AOE attacks

This was linked to issues Oct 12, 2020
aoe doesn't work for multiple targets #87
Closed
damage isn't calculated properly for some weapons #86
Closed
Damage taken after enemy is destroyed #28
Closed
find out what movement type 7 does #83
Closed
@MickVermeulen MickVermeulen self-assigned this Oct 12, 2020
Jettford
Jettford approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@Jettford Jettford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t see any issues and it is nice you realised the packet handler issue when you did

@MickVermeulen MickVermeulen merged commit 8694b70 into master Oct 13, 2020
@MickVermeulen MickVermeulen deleted the damage-calculation branch October 13, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jettford Jettford Jettford approved these changes

Assignees

@MickVermeulen MickVermeulen

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@MickVermeulen @Jettford