Skip to content

Persist Selected Consumables #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 22, 2022
Merged

Persist Selected Consumables #326

merged 6 commits into from
Feb 22, 2022

Conversation

TheNexusAvenger
Copy link
Member

Closes #192

This pull request:

  • Makes selected consumables persist between sessions. It just wasn't fully implemented.
  • Adds a helper script for creating database migrates in the future, which was used for this pull request.
    • Added a doc for academic requirements as well as covering the script above.

@TheNexusAvenger TheNexusAvenger self-assigned this Feb 9, 2022
teccheck
teccheck approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@teccheck teccheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes and they worked. The helper scripts are nice and I think they'll help a lot

@TheNexusAvenger TheNexusAvenger merged commit 5d3039d into dev Feb 22, 2022
@TheNexusAvenger TheNexusAvenger deleted the enhancement/persist-selected-consumable branch February 22, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teccheck teccheck teccheck approved these changes

@Frozenreflex Frozenreflex Frozenreflex approved these changes

Assignees

@TheNexusAvenger TheNexusAvenger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selected Skills In Action Bar Don't Persist
3 participants
@TheNexusAvenger @teccheck @Frozenreflex