Skip to content

Use External Logging Library #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 31, 2021
Merged

Conversation

TheNexusAvenger
Copy link
Member

This pull request moves our currently logging code to an external library, including a few enhancements

  • Add line wrapping for long messages.
  • Improve the design of the logging code.
  • Allow additional information to be stored with logs, like the server that generated the log entry. Mainly needed for combined logs, like when deployed in a single Docker container.

The reason this was made a "Nexus" library instead of a "Uchu" library is that I intend to use this for a few other projects, although it will be some time before they are public (trying to do a month-long stability test with the first one).

Copy link
Member

@enteryournamehere enteryournamehere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, I especially like that it now breaks lines at spaces so full words aren't split up (where possible).

@TheNexusAvenger TheNexusAvenger merged commit 211563d into dev Aug 31, 2021
@TheNexusAvenger TheNexusAvenger deleted the enhancement/logging-library branch August 31, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants