-
Notifications
You must be signed in to change notification settings - Fork 19
Nexus Tower Scripts #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nexus Tower Scripts #272
Conversation
Sentinel baggage scanner near the entrance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just had one discussion point
Known issue: countdown timer doesn't display orange time-elapsed indicator after first use of combat challenge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I did notice a lot of use of this
, which is redundant as I've said before. No worries if this is the style you're going for now but it's not consistent with the MS styelguide afaik.
It is indeed not part of the MS style guide, but as @TheNexusAvenger preferred it I've started using it as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As usual, great set of improvements. Got a few comments.
Paradox
Assembly
Venture League
Sentinels
General
More things
This is meant to be a complete list of NT-specific things that don't work, so please let me know if I've missed anything.