Skip to content

Add Minigame Provisioning #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 25, 2021
Merged

Conversation

TheNexusAvenger
Copy link
Member

This does not close any issues

This pull request adds provisioning of matches, such as Avant Gardens Survival. The implementation is incomplete but is blocked by other features not existing and will be handled by other pull requests later.
Demo of the feature: https://imgur.com/CaPaaYv

The following are not implemented at this point:

  • Resetting the time on the client, like when a player leaves the match from a race. (Not at the point of testing this, and I couldn't find a relevant packet capture)
  • Matches aren't limited to teams. (Teams aren't implemented; only the packets)
  • Zones aren't re-used or cleared when completed.
  • Matches are limited to the current zone instead of all zones. This should be another feature to allow for central servers for chat, teams, and matches.
  • Preventing players logging into minigame zones, such as after leaving a minigame by logging out or the server crashing.
  • AG Survival isn't implemented.

Copy link
Member

@MickVermeulen MickVermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a few minor comments, overall very nice work, especially on the RE side of things!

@MickVermeulen
Copy link
Member

Looking good, feel free to merge :)

@TheNexusAvenger TheNexusAvenger merged commit 116992f into dev Feb 25, 2021
@TheNexusAvenger TheNexusAvenger deleted the enhancement/minigame-provisioning branch February 25, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants