Fix Missions Requiring Active Missions #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #184
Closes #172
This pull request fixes the problem of certain missions, such as The Ninja Masters and Yay for Spray, which requires 3 other missions to be completed, being unable to be started. This also fixes the design flaw where an available mission may be given if there is another active or complete mission if the mission giver stores the available mission before the others.
I tested this branch with the first 28 missions in Avant Gardens except for using
/completeon the Avant Gardens survival mission. There is currently a bug where the achiever missions, the missions that require getting 10, then 20, then 30... missions/achievements, all complete together, but this isn't a problem introduced with this branch. See: #198