Skip to content

Improve Moving Platforms #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 20, 2021
Merged

Improve Moving Platforms #204

merged 15 commits into from
Feb 20, 2021

Conversation

TheNexusAvenger
Copy link
Member

Closes #170

This pull request attempts to improve the functionality of moving platforms. The changes include:

  • Fix platforms teleporting due to incorrect timings.
  • Fix platforms on Crux Prime not moving by default.
  • Fix players teleporting off platforms.
  • Fix platforms being mid-movement during quick builds.
  • Implement the bus door script.

@MickVermeulen MickVermeulen self-requested a review February 18, 2021 19:31
MickVermeulen
MickVermeulen reviewed Feb 18, 2021
View reviewed changes
Copy link
Member

@MickVermeulen MickVermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great change, overall just a few discussion points and style changes.

@MickVermeulen MickVermeulen merged commit 55efc28 into dev Feb 20, 2021
@MickVermeulen MickVermeulen deleted the enhancement/improve-platforms branch February 20, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MickVermeulen MickVermeulen MickVermeulen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Platforms Aren't Implemented Correctly
2 participants
@TheNexusAvenger @MickVermeulen