Skip to content

Improve Maelstrom Vacuum #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2021
Merged

Improve Maelstrom Vacuum #158

merged 2 commits into from
Jan 12, 2021

Conversation

TheNexusAvenger
Copy link
Member

Closes #66 and #80

This pull request resolves a bug that the Maelstrom vacuum could only pick up 1 sample without rebooting, with the server tick processing sometimes stopping, as well as adding the missing animations for not being in range and actually collecting.

@TheNexusAvenger TheNexusAvenger linked an issue Jan 12, 2021 that may be closed by this pull request
paradox vacuum doesn't suck bricks #80
Closed
MickVermeulen
MickVermeulen requested changes Jan 12, 2021
View reviewed changes
Copy link
Member

@MickVermeulen MickVermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor style stuff. For the record: could you report a bit on what actually caused the issue? I presume it was serialization given that an animation was played that causes the server to be stuck at 55%?

@TheNexusAvenger
Copy link
Member Author

For the record: could you report a bit on what actually caused the issue? I presume it was serialization given that an animation was played that causes the server to be stuck at 55%?

¯_(ツ)_/¯
I was informed it was the problem and was able to reproduce the problem went away with the fix in the first commit. I never dug into why it became a problem, and why in some cases the server tick would stop processing.

@Jettford Jettford merged commit dd82d05 into dev Jan 12, 2021
@TheNexusAvenger TheNexusAvenger deleted the enhancement/improve-maelstrom-vacuum branch January 16, 2021 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MickVermeulen MickVermeulen MickVermeulen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

paradox vacuum doesn't suck bricks 55% load issue on AG
3 participants
@TheNexusAvenger @MickVermeulen @Jettford