Add Authorization Port Configuration #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related (already closed) issue: #152
This change allows the server owner to configure the port used by the Authorization server from the hardcoded 21836 to an arbitrary port. This may not get much use given it requires users to explicitly define the port and use the next release of lcdr's RakNet shim, but does reduce a hardcoded number that requires a code change if someone really needed a custom port.
The change was tested with the arbitrary port 20000 using the latest code from lcdr's RakNet shim repository using
cargo build --releaseto build. It was also tested in the stock configuration (port 21836). Both cases allowed me to log in, select a character, and play in Avant Gardens.