Skip to content

Block client commands being responded to by the server #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 19, 2020

Conversation

Jettford
Copy link
Member

No description provided.

@MickVermeulen
Copy link
Member

MickVermeulen commented Oct 19, 2020

So two small things: I know I didn't tell you this before but I think it might be better to have the client commands array as a static property on the SocialHandler, that way it's not built every time this is called, so private static string[] ClientCommands { get; } = {""};, also it might be nice to format the client commands using newlines a bit so that they don't cross the 120 character mark, makes it easier to read which commands there are without having to scroll to the right.

@Jettford
Copy link
Member Author

Oh yeah you did tell me, I will do that now

@Jettford
Copy link
Member Author

Fixed, going to merge

@Jettford Jettford merged commit 0dcfccb into master Oct 19, 2020
@Jettford Jettford deleted the chat-refactor branch October 19, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants