Skip to content

Fixes CI Version string and file version creation #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

smaillet
Copy link
Member

@smaillet smaillet commented Jul 8, 2025

Fixes #64
This fixes the bug where CI version strings are ignoring the Patch+1 design

  • Removed ignored ShortCSemVer support
    • Not used, not tested and therefore fragile and likely incorrect
  • Added IsCIBuild property to task to make it simpler to centralize the evaluation of that state.
  • Added automatic conversion of "prerelease" to "pre" as a CSemVer pre-release name.
  • Added Patch+1 support to creation of the version string for CI builds
  • Added clarifying docs
  • Added Build scripting to correctly form a CI build string AND FileVersion for a CI build.

This fixes the bug where CI version strings are ignoring the Patch+1 design
* Removed ignored ShortCSemVer support
    - Not used, not tested and therefore fragile and likely incorrect
* Added IsCIBuild property to task to make it simpler to centralize the evaluation of that state.
* Added automatic conversion of "prerelease" to "pre" as a CSemVer pre-release name.
* Added Patch+1 support to creation of the version string for CI builds
* Added clarifying docs
* Added Build scripting to correctly form a CI build string AND FileVersion for a CI build.
@smaillet smaillet changed the title Fixes #64 Fixes CI Version string and file version creation Jul 8, 2025
Copy link

github-actions bot commented Jul 8, 2025

Test Results

53 tests   53 ✅  21s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 5773da5.

@smaillet smaillet merged commit 2107b54 into UbiquityDotNET:develop Jul 8, 2025
3 checks passed
@smaillet smaillet deleted the BugFix64 branch July 8, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - CI Version string is generated incorrectly
1 participant